Dress the capture environment per platform, and drive the menu by keyboard #2
No reviewers
Labels
No labels
⏳in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grey.ooo/someones.computer_tray!2
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/themed-capture"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The first captures were a bare GTK desktop on black: fine for finding defects, wrong for a manual. This dresses the capture environment per platform, makes the walk survive a theme change, and writes down the policy the whole thing serves.
Dressing
themes/{macos,windows,linux}.css— a GTK stylesheet, a panel colour and a desktop colour each.run.shcaptures all three.It is dressing, and the docs say so twice. These are Linux GTK menus wearing other platforms' colours. A shot claiming to be a macOS capture has to come off a Mac, which needs a runner this project doesn't have. What the dressing buys is a manual whose illustrations don't fight the reader.
The walk is by keyboard now
Row heights move with the theme, the font, and any label that changes length — and a coordinate-driven walk that misses its submenu still writes a plausible-looking PNG. That happened twice here before it was noticed.
xdotool key Down/Rightfollows the menu wherever it goes, and GTK'sRightselects the first child, so the walk is three keys deep rather than five.Also: a compositor, because the host paints its panel transparent and without one that isn't transparency, it's whatever was in the framebuffer; and
hsetrootinstead ofxsetroot, which is the half of a desktop colour a compositor actually reads.The policy
In the README, and the reason any of this exists:
docs/images/is the review.The suite and the generated manual are tracked in #627; this PR is the harness and the captures of the toggle work.
Verified
go build,go vet,go testclean; captures regenerated for all three themes and each one read before committing.