Pin scclient to the variable/delete verbs, tidy, and vendor #1
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/scclient-pin-and-vendor"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The provider's first commit pinned scclient at
c2999f98d576("managed-service verbs") — the commit before30e90650744f("Wrap the variable, application-delete and isolation-create verbs"). It callsVariable/Variables,CreateApplicationWithIsolationandDeleteApplication, all introduced by the latter, so it never compiled against its own pin. It also shipped nogo.sumand novendor/, so it could not build reproducibly.What
v0.0.0-20260819205411-30e90650744f.go mod tidy: adds the missing indirect requires and raises the go directive to 1.25.8 andterraform-plugin-goto v0.31.0 — the minimums the plugin-framework/plugin-testing graph requires; the original go.mod was never tidied.go.sumand avendor/tree, matchingagent/'s vendored-scclient model (no replace directive). Module hashes are content-derived, sogo.summatches the registry once30e90650744fis released.Verification
Offline, with the CI invocation (
-mod=vendor GOWORK=off GOPROXY=off): build, unit + acceptance tests, coverage gate 72.8% (on floor),go vet, andhack/lint.sh(golangci-lint v2.6.1) 0 issues — all green.Follow-up
30e90650744fis currently only on scclient'sfeature/terraform-variable-wrappers; merging that to scclient main (and tagging) is what lets a from-scratch, non-vendored build resolve the pin. The vendored tree here is self-contained meanwhile.The provider's first commit pinned scclient at c2999f98d576 ("managed-service verbs"), the commit before 30e90650744f ("Wrap the variable, application-delete and isolation-create verbs"). It calls Variable/Variables, CreateApplicationWithIsolation and DeleteApplication — all introduced by the latter — so it never compiled against its own pin. It also shipped no go.sum and no vendor tree, so it could not build reproducibly. - Bump the scclient require to v0.0.0-20260819205411-30e90650744f. - go mod tidy: adds the missing indirect requires and raises the go directive to 1.25.8 and terraform-plugin-go to v0.31.0 — the minimums the plugin-framework and plugin-testing graph actually requires; the original go.mod was never tidied. - Commit go.sum and a vendor/ tree, matching agent/'s vendored-scclient CI model (no replace directive). Module hashes are content-derived, so go.sum matches the registry once 30e90650744f is released. Verified offline with the CI invocation (-mod=vendor GOWORK=off GOPROXY=off): build, unit + acceptance tests, coverage gate 72.8% (on floor), go vet, and hack/lint.sh (golangci-lint v2.6.1, 0 issues) all green.