Wrap the variable, application-delete and isolation-create verbs #11

Open
geusebio wants to merge 1 commit from feature/terraform-variable-wrappers into main
Owner

Adds the /cli wrappers the new Terraform provider needs, keeping one
definition of each verb on the shared contract (the reason this module exists).

What

  • Variables / SetVariables / DeleteVariable — the application
    configuration layer (GET/PUT/DELETE /cli/applications/{slug}/variables).
    Values are never on the wire, so Variable carries metadata only.
  • DeleteApplicationDELETE /cli/applications/{slug}, with ?force for a
    still-bound managed service. Paired with the platform's new endpoint (separate PR).
  • CreateApplicationWithIsolation — a superset of CreateApplication naming
    the isolation level. The 3-arg form delegates and omits the key when unset, so
    the platform still applies its default and the agent's one caller is untouched.

Verification

  • go test ./... green; hack/lint.sh reports 0 issues.
  • Coverage ratchet 88.8 → 90.7% (floor bumped in this commit).
  • Stdlib only — no new dependencies.
Adds the `/cli` wrappers the new Terraform provider needs, keeping one definition of each verb on the shared contract (the reason this module exists). ## What - **`Variables` / `SetVariables` / `DeleteVariable`** — the application configuration layer (`GET`/`PUT`/`DELETE /cli/applications/{slug}/variables`). Values are never on the wire, so `Variable` carries metadata only. - **`DeleteApplication`** — `DELETE /cli/applications/{slug}`, with `?force` for a still-bound managed service. Paired with the platform's new endpoint (separate PR). - **`CreateApplicationWithIsolation`** — a superset of `CreateApplication` naming the isolation level. The 3-arg form delegates and omits the key when unset, so the platform still applies its default and the agent's one caller is untouched. ## Verification - `go test ./...` green; `hack/lint.sh` reports 0 issues. - Coverage ratchet 88.8 → **90.7%** (floor bumped in this commit). - Stdlib only — no new dependencies.
Wrap the variable, application-delete and isolation-create verbs
All checks were successful
CI / build (pull_request) Successful in 1m24s
30e9065074
Adds the wrappers a declarative consumer (the new Terraform provider) needs and
the CLI did not yet require, keeping one definition of each verb on the contract:

- Variables/SetVariables/DeleteVariable — the application configuration layer
  (GET/PUT/DELETE /cli/applications/{slug}/variables). Values are never on the
  wire, so Variable carries metadata only.
- DeleteApplication — DELETE /cli/applications/{slug}, with ?force for a still-
  bound managed service. Paired with the platform's new endpoint.
- CreateApplicationWithIsolation — a superset of CreateApplication that names the
  isolation level; the 3-arg form delegates to it and omits the key when unset,
  so the platform still reads its default and the agent's caller is untouched.

Stdlib only, matching the module's no-dependency rule. Coverage floor 88.8 -> 90.7.
All checks were successful
CI / build (pull_request) Successful in 1m24s
This pull request has changes conflicting with the target branch.
  • README.md
  • client/cliapi_test.go
  • coverage.floor
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feature/terraform-variable-wrappers:feature/terraform-variable-wrappers
git switch feature/terraform-variable-wrappers

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff feature/terraform-variable-wrappers
git switch feature/terraform-variable-wrappers
git rebase main
git switch main
git merge --ff-only feature/terraform-variable-wrappers
git switch feature/terraform-variable-wrappers
git rebase main
git switch main
git merge --no-ff feature/terraform-variable-wrappers
git switch main
git merge --squash feature/terraform-variable-wrappers
git switch main
git merge --ff-only feature/terraform-variable-wrappers
git switch main
git merge feature/terraform-variable-wrappers
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grey.ooo/someones.computer_scclient!11
No description provided.