Add --browser to sc deploy and sc start #42
No reviewers
Labels
No labels
⏳in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grey.ooo/someones.computer_agent!42
Loading…
Reference in a new issue
No description provided.
Delete branch "feature/browser-flag-auto-open-urls"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
--browsertosc deploy(andsc start, which follows a revisionthrough the same stream) so the client opens what it already prints:
the build-monitor page as soon as it is served, and the failure page
too if the build lands badly.
convenience, not the only way to reach them.
openBrowseris now a package var so tests can substitute it insteadof actually spawning a browser.
Test plan
go build ./...go test ./...go vet ./...golangci-lint run ./...gofmt -l .(clean)hack/coverage.sh—internal/clirose from 80.7% to 85.9%, nopackage fell below its floor
WIP: Add --browser to sc deploy and sc startto Add --browser to sc deploy and sc start