Add --browser to sc deploy and sc start #42

Merged
geusebio merged 2 commits from feature/browser-flag-auto-open-urls into main 2026-08-25 15:25:34 +00:00
Owner

Summary

  • Add --browser to sc deploy (and sc start, which follows a revision
    through the same stream) so the client opens what it already prints:
    the build-monitor page as soon as it is served, and the failure page
    too if the build lands badly.
  • Off by default. Every URL is still printed either way — this is a
    convenience, not the only way to reach them.
  • openBrowser is now a package var so tests can substitute it instead
    of actually spawning a browser.

Test plan

  • go build ./...
  • go test ./...
  • go vet ./...
  • golangci-lint run ./...
  • gofmt -l . (clean)
  • hack/coverage.shinternal/cli rose from 80.7% to 85.9%, no
    package fell below its floor
## Summary - Add `--browser` to `sc deploy` (and `sc start`, which follows a revision through the same stream) so the client opens what it already prints: the build-monitor page as soon as it is served, and the failure page too if the build lands badly. - Off by default. Every URL is still printed either way — this is a convenience, not the only way to reach them. - `openBrowser` is now a package var so tests can substitute it instead of actually spawning a browser. ## Test plan - [x] `go build ./...` - [x] `go test ./...` - [x] `go vet ./...` - [x] `golangci-lint run ./...` - [x] `gofmt -l .` (clean) - [x] `hack/coverage.sh` — `internal/cli` rose from 80.7% to 85.9%, no package fell below its floor
Add --browser to sc deploy and sc start
All checks were successful
CI / build (pull_request) Successful in 5m0s
f3ef78e9f3
Opens the build-monitor page as soon as it is printed, and the failure
page too if the revision lands badly. Off by default: every URL this
client prints is printed regardless, so this is a convenience rather
than the only way to reach them.
geusebio changed title from WIP: Add --browser to sc deploy and sc start to Add --browser to sc deploy and sc start 2026-08-25 14:54:22 +00:00
Merge remote-tracking branch 'origin/main' into feature/browser-flag-auto-open-urls
All checks were successful
CI / build (pull_request) Successful in 34s
996aba9677
# Conflicts:
#	internal/cli/deploy.go
geusebio deleted branch feature/browser-flag-auto-open-urls 2026-08-25 15:25:34 +00:00
Sign in to join this conversation.
No reviewers
No labels
in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grey.ooo/someones.computer_agent!42
No description provided.