Don't call an unstyled top bar drift; it means the page wasn't ready #17
No reviewers
Labels
No labels
brandkit-conformance
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Grey.ooo/symfony-brand-kit!17
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/unstyled-chrome-is-inconclusive"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The first live run filed #16 against PrintShop, telling an entirely up-to-date app that it was pinned to an old
grey-ooo/brand-kitand should runcomposer update. It is a false positive, and the mechanism is worth writing down.What happened
From the CI runner,
printshop.grey.oooanswered with its@splashinterstitial — visible in the debug toolbar of the screenshot the job attached to #16. That page carries the topbar markup and the full six-entry roster, but notbrand-kit.css.The result measures as:
1394pxbar--gooo-*token resolving to emptyThe confirmation pass is powerless against it: the splash is served consistently on a cold hit, so both visits agreed perfectly on the same wrong answer. Local runs never reproduced it because a warm app serves the real page and conforms.
Gating measurement on
load— added while building this — did not help either. The splash had loaded.The fix
Wait for the stylesheet to have visibly taken effect (the bar actually being
--gooo-topbar-htall), and if it never does, refuse to judge the app at all: recorded as unreachable, run goes red, the app's ticket left exactly as it was.This follows the rule the harness already claimed to follow and didn't quite: chrome present but unstyled means "the page wasn't ready", not "this app is stale".
It gives up ticketing a stylesheet that genuinely 404s. That is the right trade — a missing sheet is hardly ever explained by the consumer's version pin, and the pin is the only thing a drift ticket knows how to say.
badResourcesinsummary.jsonstill separates a real 404 from an app that was mid-boot, and now carries into the failure message.The height check therefore stops being a finding and becomes the gate, so it is gone from the checks list. The empty-token case it used to double up on is reachable on its own now.
Verification
brand-kit.cssagainst a live app reproduces the exact1394pxsignature and is now thrown as inconclusive rather than checked as drift.Follow-up
#16 should be closed as a false positive once this is on
main; the next run will not re-file it. Left open for now so the evidence stays attached to it.PrintShop's splash is expected behaviour, not a defect:
printshop.grey.ooois a stagingdeployment, so it runs in debug mode and serves its assets through PHP, which is what makes
a cold hit slow enough to show an interstitial at all. It is still the canonical PrintShop
URL in
GreyOooApps::ALLand the one users reach from the switcher, so it stays in scope forconformance — this fix is what makes checking it reliable rather than a reason to drop it.