Grey.ooo/someones.computer_tray
Watch
5
0
Fork
You've already forked someones.computer_tray
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bump scclient so sc-tray's poll stops truncating past the first page #15

Merged
geusebio merged 1 commit from feature/applications-loop-on-hasmore into main 2026-08-18 20:18:23 +00:00
Conversation 0 Commits 1 Files changed 5 +361 -13
geusebio commented 2026-08-18 20:05:59 +00:00
Owner
Copy link

Why

sc-tray's poll (App.sync()) treats scclient.Client.Applications()'s return value as the complete tree it draws from — it always has. A tenant past the default 100-application page got a silently partial menu once the endpoint started bounding itself to one page per response (platform #587/#887).

What changed

Bumps scclient to someones.computer_scclient#10, which teaches Applications() to loop across every page itself. No source change in this repo: sync() never had page-awareness of its own, so this is the dependency bump plus go mod vendor.

Verified

  • go build ./..., go vet ./..., go test ./... all green; gofmt -l clean.
  • hack/coverage.sh — all three packages hold their floor exactly (no source lines changed here, so no movement expected).
  • No new Go test added. sync() draws through the real systray backend (menu items, no injectable client interface), which is why this repo verifies that path with the screenshot-based visual E2E suite (#627, hack/screenshot/scenes/) rather than Go unit tests — none of the existing scenes exercise a paginated response either. A large-tenant capture scene would be the natural way to cover this end to end; flagging it as a follow-up rather than silently skipping verification here, since the dev seed's largest case (41 applications) never crosses the default page.

One of three coordinated PRs for Grey.ooo/Someones.Computer#894 — see scclient#10's body for the other two (this one, and sc's). Draft until scclient#10 merges — this currently points at its feature branch commit, not main.

## Why `sc-tray`'s poll (`App.sync()`) treats `scclient.Client.Applications()`'s return value as the complete tree it draws from — it always has. A tenant past the default 100-application page got a silently partial menu once the endpoint started bounding itself to one page per response ([platform #587/#887](https://git.grey.ooo/Grey.ooo/Someones.Computer/issues/887)). ## What changed Bumps `scclient` to [someones.computer_scclient#10](https://git.grey.ooo/Grey.ooo/someones.computer_scclient/pulls/10), which teaches `Applications()` to loop across every page itself. No source change in this repo: `sync()` never had page-awareness of its own, so this is the dependency bump plus `go mod vendor`. ## Verified - `go build ./...`, `go vet ./...`, `go test ./...` all green; `gofmt -l` clean. - `hack/coverage.sh` — all three packages hold their floor exactly (no source lines changed here, so no movement expected). - **No new Go test added.** `sync()` draws through the real `systray` backend (menu items, no injectable client interface), which is why this repo verifies that path with the screenshot-based visual E2E suite ([#627](https://git.grey.ooo/Grey.ooo/Someones.Computer/issues/627), `hack/screenshot/scenes/`) rather than Go unit tests — none of the existing scenes exercise a paginated response either. A large-tenant capture scene would be the natural way to cover this end to end; flagging it as a follow-up rather than silently skipping verification here, since the dev seed's largest case (41 applications) never crosses the default page. One of three coordinated PRs for [Grey.ooo/Someones.Computer#894](https://git.grey.ooo/Grey.ooo/Someones.Computer/issues/894) — see [scclient#10](https://git.grey.ooo/Grey.ooo/someones.computer_scclient/pulls/10)'s body for the other two (this one, and `sc`'s). Draft until `scclient#10` merges — this currently points at its feature branch commit, not `main`.
Bump scclient so sc-tray's poll stops truncating past the first page
All checks were successful
CI / build (pull_request) Successful in 2m0s
Details
CI / captures (pull_request) Successful in 7m0s
Details
4dc45a50d5
 
Applications() now loops across every page on the server's behalf
(someones.computer_scclient#10). a.sync() already treats the return value
as the complete list, so a tenant past the default 100-application page
now draws every row instead of a silently partial menu, with no source
change needed here beyond the dependency bump.
geusebio changed title from WIP: Bump scclient so sc-tray's poll stops truncating past the first page to Bump scclient so sc-tray's poll stops truncating past the first page 2026-08-18 20:18:09 +00:00
geusebio deleted branch feature/applications-loop-on-hasmore 2026-08-18 20:18:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
⏳in-progress
Someone is actively working this right now — do not start a second pass on it

No labels
⏳in-progress
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Grey.ooo/someones.computer_tray!15
No description provided.