Make the golden menu describe the menu main actually draws #11

Merged

geusebio merged 1 commit from fix/golden-matches-main into main

2026-08-17 15:45:32 +00:00

geusebio commented

2026-08-15 14:19:35 +00:00

Owner

The menu assertion landed by cherry-pick from a branch that also added an Open dashboard row, so the golden file arrived on main claiming a row main does not draw. check.sh would have failed on main until the branch behind it merged — and a golden file has to describe the code it sits beside, whatever is queued behind it.

Caught by the check itself, which is the first useful thing it has said.

Also: run.sh now builds both binaries. It built only sc-tray, so a fresh checkout could not build the capture image at all — neither binary is committed, and the one nobody had locally was the one nobody noticed was missing.

The menu assertion landed by cherry-pick from a branch that *also* added an `Open dashboard` row, so the golden file arrived on main claiming a row main does not draw. `check.sh` would have failed on main until the branch behind it merged — and a golden file has to describe the code it sits beside, whatever is queued behind it. Caught by the check itself, which is the first useful thing it has said. Also: `run.sh` now builds **both** binaries. It built only `sc-tray`, so a fresh checkout could not build the capture image at all — neither binary is committed, and the one nobody had locally was the one nobody noticed was missing.

geusebio added 1 commit

2026-08-15 14:19:35 +00:00

Make the golden menu describe the menu main actually draws

CI / build (pull_request) Successful in 3m21s

Details

ee8b7762ed

The assertion landed by cherry-pick from a branch that also added an Open
dashboard row, so the golden file arrived claiming a row main does not draw —
which would have failed check.sh on main until the branch behind it merged. A
golden file has to describe the code it sits beside, whatever is queued.

Caught by the check itself, which is the first thing it has usefully said.

run.sh also builds the dumper now. It built only sc-tray, so a fresh checkout
could not build the capture image at all — neither binary is committed, and
the one nobody had locally was the one nobody noticed missing.

geusebio merged commit 1cadb677b1 into main

2026-08-17 15:45:32 +00:00

geusebio deleted branch fix/golden-matches-main

2026-08-17 15:45:33 +00:00

geusebio referenced this pull request from a commit

2026-08-17 15:45:34 +00:00

Make the golden menu describe the menu main actually draws (#11)

geusebio referenced this pull request from a commit

2026-08-17 15:49:31 +00:00

Make the captures a scene per state, and generate the manual from them

geusebio referenced this pull request

2026-08-17 15:50:00 +00:00