Bump scclient so sc apps stops truncating past the first page #32

Merged

geusebio merged 1 commit from feature/applications-loop-on-hasmore into main

2026-08-18 20:18:01 +00:00

geusebio commented

2026-08-18 20:04:37 +00:00

Owner

Why

sc apps treats scclient.Client.Applications()'s return value as the complete organization → application tree — it always has. That was wrong once the endpoint started bounding itself to one page (platform #587/#887): a tenant past the default 100-application page got a silently partial tree with no indication anything was missing.

What changed

Bumps scclient to someones.computer_scclient#10, which teaches Applications() to loop across every page itself. No change to this repo's own source: apps.go never had page-awareness of its own to add or remove, so the fix is entirely the dependency bump plus go mod vendor.

Verified

New end-to-end test (TestAppsDrawsApplicationsFromEveryPageNotJustTheFirst) runs sc apps against a fake platform whose applications span two pages and asserts the tree carries applications from both, not just the first.
go build ./..., go vet ./..., go test ./... all green; gofmt -l clean on the changed file.
hack/coverage.sh: internal/cli 85.8%, above its 80.7% floor.

One of three coordinated PRs for Grey.ooo/Someones.Computer#894 — see scclient#10's body for the other two (this one, and tray's). Draft until scclient#10 merges — this currently points at its feature branch commit, not main.

## Why `sc apps` treats `scclient.Client.Applications()`'s return value as the complete organization → application tree — it always has. That was wrong once the endpoint started bounding itself to one page ([platform #587/#887](https://git.grey.ooo/Grey.ooo/Someones.Computer/issues/887)): a tenant past the default 100-application page got a silently partial tree with no indication anything was missing. ## What changed Bumps `scclient` to [someones.computer_scclient#10](https://git.grey.ooo/Grey.ooo/someones.computer_scclient/pulls/10), which teaches `Applications()` to loop across every page itself. No change to this repo's own source: `apps.go` never had page-awareness of its own to add or remove, so the fix is entirely the dependency bump plus `go mod vendor`. ## Verified - New end-to-end test (`TestAppsDrawsApplicationsFromEveryPageNotJustTheFirst`) runs `sc apps` against a fake platform whose applications span two pages and asserts the tree carries applications from both, not just the first. - `go build ./...`, `go vet ./...`, `go test ./...` all green; `gofmt -l` clean on the changed file. - `hack/coverage.sh`: `internal/cli` 85.8%, above its 80.7% floor. One of three coordinated PRs for [Grey.ooo/Someones.Computer#894](https://git.grey.ooo/Grey.ooo/Someones.Computer/issues/894) — see [scclient#10](https://git.grey.ooo/Grey.ooo/someones.computer_scclient/pulls/10)'s body for the other two (this one, and `tray`'s). Draft until `scclient#10` merges — this currently points at its feature branch commit, not `main`.

geusebio added 1 commit

2026-08-18 20:04:38 +00:00

Bump scclient so sc apps stops truncating past the first page

CI / build (pull_request) Successful in 1m11s

Details

dd4c589afe

Applications() now loops across every page on the server's behalf
(someones.computer_scclient#10), so a tenant past the default 100-application
page draws its whole tree instead of a silently partial one. No source
change needed here — apps.go already treats the return value as the
complete list — just the dependency bump and a test proving the plumbing
carries it through end to end.

geusebio changed title from ~~WIP: Bump scclient so sc apps stops truncating past the first page~~ to Bump scclient so sc apps stops truncating past the first page

2026-08-18 20:17:53 +00:00

geusebio merged commit 1cb4a0ef82 into main

2026-08-18 20:18:00 +00:00

geusebio deleted branch feature/applications-loop-on-hasmore

2026-08-18 20:18:02 +00:00

geusebio referenced this pull request from a commit

2026-08-18 20:18:02 +00:00

Bump scclient so sc apps stops truncating past the first page (#32)