Consume the shared scclient module for the /cli client and credentials #19

Merged

geusebio merged 2 commits from feature/consume-scclient into main

2026-08-08 12:47:37 +00:00

geusebio commented

2026-08-08 11:26:29 +00:00

Owner

What

Move the wire-contract half of internal/client (the /cli reads, FollowLogs, APIError, the request/error discipline) and the whole credential store to the new shared module someones.computer_scclient, so sc and the incoming sc-tray consume one client instead of forking it. Part of the tray-app plan (platform repo docs/tray-app.md).

What stays here is what sc alone owns:

internal/upload (was the other half of internal/client) — the multipart bundle upload and its progress seam, now composing on scclient's exported NewRequest/HTTPClient
internal/config — the .sc.yml project file only; the credential store is scclient's config package now (same file on disk, same semantics — sc login still writes it, sc-tray reads it)

Why the vendor directory

The scclient module is private and Forgejo's Actions token is repo-scoped, so a module fetch inside CI has no credential. Vendoring makes every build offline and deterministic; the goreleaser go mod tidy hook goes for the same reason. Local development against an unpushed scclient goes through the platform repo's go.work spanning the submodules. If a cross-repo deploy token lands later, the vendor tree can be dropped in one commit.

Verification

go vet ./..., go test ./... (all packages), go build ./... and cross-compiles for linux/amd64+arm64 and windows/amd64 — all green locally on the vendored tree, no network needed.

## What Move the wire-contract half of `internal/client` (the `/cli` reads, `FollowLogs`, `APIError`, the request/error discipline) and the whole credential store to the new shared module [`someones.computer_scclient`](https://git.grey.ooo/Grey.ooo/someones.computer_scclient), so `sc` and the incoming `sc-tray` consume one client instead of forking it. Part of the tray-app plan (platform repo `docs/tray-app.md`). What stays here is what `sc` alone owns: - **`internal/upload`** (was the other half of `internal/client`) — the multipart bundle upload and its progress seam, now composing on scclient's exported `NewRequest`/`HTTPClient` - **`internal/config`** — the `.sc.yml` project file only; the credential store is scclient's `config` package now (same file on disk, same semantics — `sc login` still writes it, sc-tray reads it) ## Why the vendor directory The scclient module is private and Forgejo's Actions token is repo-scoped, so a module fetch inside CI has no credential. Vendoring makes every build offline and deterministic; the goreleaser `go mod tidy` hook goes for the same reason. Local development against an unpushed scclient goes through the platform repo's `go.work` spanning the submodules. If a cross-repo deploy token lands later, the vendor tree can be dropped in one commit. ## Verification `go vet ./...`, `go test ./...` (all packages), `go build ./...` and cross-compiles for linux/amd64+arm64 and windows/amd64 — all green locally on the vendored tree, no network needed.

geusebio added 1 commit

2026-08-08 11:26:29 +00:00

Consume the shared scclient module for the /cli client and credentials

CI / build (pull_request) Successful in 2m26s

Details

cb8557577f

The wire-contract half of internal/client (Client, the /cli reads,
FollowLogs, APIError) and the credential store move to
git.grey.ooo/Grey.ooo/someones.computer_scclient, shared with the
sc-tray app so the contract cannot fork between its consumers. What
stays is what sc alone owns: the bundle upload (now internal/upload,
composing on scclient's NewRequest/HTTPClient seam) and the .sc.yml
project file (internal/config).

Dependencies are vendored so CI builds offline — the scclient module is
private and the Actions token is repo-scoped, so a module fetch in CI
has no credential. The goreleaser tidy hook goes for the same reason.
Local development against an unpushed scclient goes through the
platform repo's workspace instead (go.work spanning the submodules).

geusebio changed title from ~~WIP: Consume the shared scclient module for the /cli client and credentials~~ to Consume the shared scclient module for the /cli client and credentials

2026-08-08 11:33:41 +00:00

geusebio added 1 commit

2026-08-08 12:45:58 +00:00

Merge origin/main (#17 , #18 ) across the scclient extraction

CI / build (pull_request) Successful in 4m57s

Details

84570a51a1

Two resolutions beyond what git managed alone:

- #17's refusal decoding landed in files this branch moved to the
  scclient module, so its substance moved there too: apiErrorFrom is
  now scclient's exported APIErrorFrom (pushed as 4dda771), the upload
  wraps it from its new home in internal/upload, and the upload's
  refusal test came along as internal/upload/client_test.go. The /cli
  half of the old test file already lives in scclient's suite.
- vendor/ regenerated against the bumped scclient rather than keeping
  git's rename-followed auto-merge of the vendored copy.

geusebio merged commit 9d701c8095 into main

2026-08-08 12:47:37 +00:00

geusebio referenced this pull request from a commit

2026-08-08 12:47:38 +00:00

Merge pull request 'Consume the shared scclient module for the /cli client and credentials' (#19) from feature/consume-scclient into main