Drop the unused TAGGED job env from the release workflow #14

Merged

geusebio merged 1 commit from chore/drop-unused-tagged-env into main

2026-08-06 14:21:03 +00:00

geusebio commented

2026-08-06 14:19:37 +00:00

Owner

The goreleaser job set a TAGGED env var and nothing ever read it. All three
steps that care about the tag test spell it out inline instead:

Step	Condition
`Release`	`startsWith(github.ref, 'refs/tags/v')`
`Build a snapshot`	`!startsWith(github.ref, 'refs/tags/v')`
`Mirror to someones.computer`	`CHANNEL: ${{ startsWith(...) && 'stable' \|\| 'dev' }}`

Removed rather than threaded through those conditions, because only two of the
three could have used it — the env context is not available where CHANNEL is
defined, so a variable named for the tag test would still have left that test
written out longhand. That half-application is what let it sit unread.

No behaviour change. The conditions and the channel selection are byte-identical;
only the two dead lines are gone.

Verified

No TAGGED reference remains anywhere in the repo.
The workflow still parses, and the job retains all six steps in order:
checkout → setup-go → Install GoReleaser → Release → Build a snapshot →
Mirror to someones.computer.
go vet ./... and go test ./... are clean (untouched by this, checked anyway).

Not tagged [skip ci]: a change to a workflow file is a CI change however
docs-like it looks.

Spotted while driving #13 to green.

The `goreleaser` job set a `TAGGED` env var and nothing ever read it. All three steps that care about the tag test spell it out inline instead: | Step | Condition | |---|---| | `Release` | `startsWith(github.ref, 'refs/tags/v')` | | `Build a snapshot` | `!startsWith(github.ref, 'refs/tags/v')` | | `Mirror to someones.computer` | `CHANNEL: ${{ startsWith(...) && 'stable' \|\| 'dev' }}` | Removed rather than threaded through those conditions, because only two of the three could have used it — the `env` context is not available where `CHANNEL` is defined, so a variable named for the tag test would still have left that test written out longhand. That half-application is what let it sit unread. **No behaviour change.** The conditions and the channel selection are byte-identical; only the two dead lines are gone. ## Verified - No `TAGGED` reference remains anywhere in the repo. - The workflow still parses, and the job retains all six steps in order: checkout → setup-go → Install GoReleaser → Release → Build a snapshot → Mirror to someones.computer. - `go vet ./...` and `go test ./...` are clean (untouched by this, checked anyway). Not tagged `[skip ci]`: a change to a workflow file is a CI change however docs-like it looks. Spotted while driving #13 to green.

geusebio added 1 commit

2026-08-06 14:19:37 +00:00

Drop the unused TAGGED job env from the release workflow

CI / build (pull_request) Successful in 1m59s

Details

dd9e1cd92e

The `goreleaser` job set `TAGGED` and nothing ever read it: the `Release`
step, the `Build a snapshot` step and the `Mirror to someones.computer`
step each evaluate `startsWith(github.ref, 'refs/tags/v')` inline instead.

Removing it rather than threading it through the three conditions, because
only two of them could use it — the `env` context is not available where
`CHANNEL` is defined, so a variable named for the tag test would still
leave that test spelled out longhand, which is the inconsistency that let
this go unnoticed in the first place.

No behaviour change: the conditions and the channel selection are untouched.

geusebio added the

⏳in-progress

label

2026-08-06 14:19:46 +00:00

geusebio started working

2026-08-06 14:19:46 +00:00

geusebio merged commit 600f56b4cc into main

2026-08-06 14:21:03 +00:00

geusebio stopped working

2026-08-06 14:21:04 +00:00

1 minute 18 seconds

geusebio referenced this pull request from a commit